-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly precompile register_llvm_rules #1303
Conversation
Before:
After:
|
Fixes #776 |
#776 is mostly about the time it takes if anything in here is invalidated. When that issue was opened the package was just as quick to load on its own as shown here, it was in combination with other packages it got slow. |
Is that still the case? I could additionally break the call edge by using invokelatest. |
|
To me, something like KristofferC@4246ddb#diff-21145f7299f4174cfb41f7c0c845a0ee798fc065bae0a352171552dc4b810508R1033 feels correct it just has to be ensured that the actual callbacks themselves that end up getting run during runtime gets properly optimized (but not the code that generates and inserts them). |
Reduces loading time on my system significantly from ~10s to 0.3s